Fix epoch update in TestValidator::change_resource_control_policy#3540
Merged
jvff merged 2 commits intolinera-io:mainfrom Mar 11, 2025
Merged
Conversation
Update to use the new operation that relies on the emitted event instead of a message sent through the subscription channel.
The admin chain is already in the new epoch, and fails to process it again.
ma2bd
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Epoch changes were recently changed to use events (#3432), but the
TestValidator::change_resource_control_policywas still trying to receive epoch change system messages instead of creating an operation to process the new epoch.Proposal
Use the new
SystemOperation::ProcessNewEpochto update the chains to use the new epoch, and skip updating the admin chain because it fails to try to process the same epoch twice.Test Plan
Tested with a rebased version of the tests in #3509. The tests stop working after #3432 but pass again after this PR.
Release Plan
Links