Support custom ResourceControlPolicy in integration tests#3505
Merged
jvff merged 5 commits intolinera-io:mainfrom Mar 8, 2025
Merged
Support custom ResourceControlPolicy in integration tests#3505jvff merged 5 commits intolinera-io:mainfrom
ResourceControlPolicy in integration tests#3505jvff merged 5 commits intolinera-io:mainfrom
Conversation
Prepare to allow tests to advance the epoch.
Remove the hard-coded initial epoch to allow proposing blocks after the chain has advanced its epoch.
Place them inside shared `Mutex`es so that they can be updated.
Allow mutating a committee's [`ResourceControlPolicy`].
Allow tests to configure the `ResourceControlPolicy` used in the tests.
afck
reviewed
Mar 8, 2025
afck
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In integration tests, the
ResourceControlPolicywas hardcoded to use the default value. With the addition of an HTTP allow list (#3427), the tests aren't able to test any HTTP requests.Proposal
Allow changing the
ResourceControlPolicyused inside a test, allowing to add hosts to the allow list. For the policy change to work, a new committee and epoch must be published. Therefore the epoch and committee can't be assumed to be constant anymore.Test Plan
Wrote some (upcoming) tests that try to perform an HTTP request without changing the policy and after adding the host to the policy, and ensured that the former fails while the latter succeeds.
Release Plan
Links