Merged
Conversation
deuszx
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to use event streams for committee changes to address the admin chain's scalability issues. Ultimately we want to replace pub-sub channels with event streams entirely. (#365)
Proposal
Write committed blocks' events to storage.
Test Plan
This doesn't use them yet, and just ports parts of #2309 to
main, so we don't have to rebase them again in the future. CI should catch any regressions, and the event functionality itself will be tested in upcoming PRs, when events are actually used.Release Plan
Links
read_eventmethod. #2309.