ExistingNet -> NetWithFaucet #3067
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-ds
force-pushed
the
12-19-existingnet_-_netwithfaucet
branch
from
b3bd9d2 to
8ca0682
Compare
|
It makes more sense but it doesn't end up with "net" like the others. I still prefer the old name remote-net. |
|
Maybe |
ma2bd
reviewed
Dec 20, 2024
| @@ -377,7 +377,7 @@ impl AmmApp { | |||
| #[cfg_attr(feature = "scylladb", test_case(LocalNetConfig::new_test(Database::ScyllaDb, Network::Grpc) ; "scylladb_grpc"))] | |||
| #[cfg_attr(feature = "dynamodb", test_case(LocalNetConfig::new_test(Database::DynamoDb, Network::Grpc) ; "aws_grpc"))] | |||
| #[cfg_attr(feature = "kubernetes", test_case(SharedLocalKubernetesNetTestingConfig::new(Network::Grpc, BuildArg::Build) ; "kubernetes_grpc"))] | |||
| #[cfg_attr(feature = "existing-net", test_case(ExistingNetTestingConfig::new(None) ; "existing_net_grpc"))] | |||
| #[cfg_attr(feature = "net-with-faucet", test_case(NetWithFaucetTestingConfig::new(None) ; "net_with_faucet_grpc"))] | |||
There was a problem hiding this comment.
#[cfg_attr(feature = "faucet", test_case(FaucetNetTestingConfig::new(None) ; "faucet_grpc"))]
ma2bd
reviewed
Dec 20, 2024
linera-service/Cargo.toml
Outdated
| @@ -54,7 +54,7 @@ kubernetes = [ | |||
| "dep:pathdiff", | |||
| "dep:fs_extra", | |||
| ] | |||
| existing-net = [] | |||
| net-with-faucet = [] | |||
There was a problem hiding this comment.
Wouldn't faucet-net be better here? Since this isn't general faucet functionality, but specific to the faucet net 🤔 I'll do faucet-net, but I can switch to faucet if you disagree
There was a problem hiding this comment.
None of that matters because we want to change things in depth
There was a problem hiding this comment.
Ok, just left it as faucet-net for now then!
ndr-ds
force-pushed
the
12-19-existingnet_-_netwithfaucet
branch
from
8ca0682 to
e721d6e
Compare
ndr-ds
force-pushed
the
12-19-existingnet_-_netwithfaucet
branch
from
e721d6e to
b18f542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As much as
ExistingNetis better than the previous name, it's still not great.Proposal
NetWithFaucetseems better and more descriptive of the network properties.Test Plan
CI
Release Plan