Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typographical Errors #3053

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix Typographical Errors #3053

wants to merge 5 commits into from

Conversation

vipocenka
Copy link

The following changes have been made:

  • Corrected the usage of articles in comments to align with grammar rules (e.g., "a" to "an" before words starting with vowel sounds).
  • Fixed various minor typographical errors in comments and docstrings across the repository.

@vipocenka
typos notifier.rs
9da1577 
Signed-off-by: Ocenka <[email protected]>
@vipocenka
typos mod.rs
59c6ebc 
Signed-off-by: Ocenka <[email protected]>
@vipocenka
typos system_execution_state.rs
3ef456a 
Signed-off-by: Ocenka <[email protected]>
@vipocenka
typos views.rs
6d0419c 
Signed-off-by: Ocenka <[email protected]>
@vipocenka
typos tuples.rs
a4597ec 
Signed-off-by: Ocenka <[email protected]>
ndr-ds
ndr-ds reviewed Dec 19, 2024
View reviewed changes
linera-views/src/views/unit_tests/views.rs
@@ -437,7 +437,7 @@ async fn test_reentrant_collection_view_has_pending_changes_after_try_load_entry
Ok(())
}

/// Check if a acquiring multiple write-locks to sub-views causes the collection to have pending
/// Check if an acquiring multiple write-locks to sub-views causes the collection to have pending
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's actually supposed to be this:

Suggested change
/// Check if an acquiring multiple write-locks to sub-views causes the collection to have pending
/// Check if acquiring multiple write-locks to sub-views causes the collection to have pending

@afck afck self-requested a review December 19, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndr-ds ndr-ds ndr-ds left review comments

@afck afck Awaiting requested review from afck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vipocenka @ndr-ds @afck