-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send Prometheus metrics to Grafana Cloud #2994
Open
ndr-ds
wants to merge
1
commit into
main
Choose a base branch
from
12-02-send_prometheus_metrics_to_grafana_cloud
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ndr-ds
force-pushed
the
12-02-send_prometheus_metrics_to_grafana_cloud
branch
from
December 2, 2024 17:52
00f28a0
to
4aa0e5d
Compare
ndr-ds
force-pushed
the
11-28-avoid_build_on_linera_net_up_--kubernetes
branch
from
December 2, 2024 21:11
a872d17
to
37758e3
Compare
ndr-ds
force-pushed
the
12-02-send_prometheus_metrics_to_grafana_cloud
branch
from
December 2, 2024 21:11
4aa0e5d
to
e11c5b7
Compare
This was referenced Dec 3, 2024
christos-h
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup.
I'm a bit confused on two things:
- Do we not still want the internal Grafana which is validator specific? In which case why is the dashboard disabled? If you don't want the dashboard why not remove Grafana entirely?
- The reference to the GCP secret should not be hard-coded in
linera-protocol
but instead be parameterised and injected by the caller inlinera-infra
(probablylineractl
).
|
ndr-ds
force-pushed
the
11-28-avoid_build_on_linera_net_up_--kubernetes
branch
from
December 3, 2024 21:33
37758e3
to
1b117c3
Compare
ndr-ds
force-pushed
the
12-02-send_prometheus_metrics_to_grafana_cloud
branch
from
December 3, 2024 21:34
e11c5b7
to
188dc33
Compare
ndr-ds
force-pushed
the
11-28-avoid_build_on_linera_net_up_--kubernetes
branch
2 times, most recently
from
December 4, 2024 14:13
6266ccd
to
3650595
Compare
ndr-ds
force-pushed
the
12-02-send_prometheus_metrics_to_grafana_cloud
branch
from
December 4, 2024 14:13
188dc33
to
17b1c8c
Compare
ndr-ds
changed the base branch from
11-28-avoid_build_on_linera_net_up_--kubernetes
to
graphite-base/2994
December 4, 2024 14:16
ndr-ds
force-pushed
the
12-02-send_prometheus_metrics_to_grafana_cloud
branch
from
December 4, 2024 14:16
17b1c8c
to
ec0f9af
Compare
ndr-ds
force-pushed
the
12-02-send_prometheus_metrics_to_grafana_cloud
branch
from
December 4, 2024 14:17
ec0f9af
to
e9fee28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're migrating our internal validators to send data to Grafana Cloud.
Proposal
Starting with the local setup. This was useful to test the required changes that we'll likely need for the actual internal validator setup. We probably won't want to send metrics to Grafana Cloud from local runs all the time (specially for cost reasons), so this is disabled by default.
Grafana Cloud credentials are stored in a secret within GCP's Secret Manager. Since Grafana Cloud will be for our internal validators, then I figured storing the secret on GCP made sense.
Test Plan
Ran locally with
linera net up --kubernetes
, and saw the metrics in our Grafana Cloud instance:Release Plan
If we want to start sending metrics to Grafana Cloud from our devnet/testnet, then:
devnet
branchtestnet
branch, then