Catch performance regressions on benchmarks #2920
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-ds
changed the title
ndr-ds
force-pushed
the
11-19-catch_performance_regressions_on_benchmark
branch
2 times, most recently
from
e47b25e to
603f16d
Compare
ndr-ds
force-pushed
the
11-19-catch_performance_regressions_on_benchmark
branch
2 times, most recently
from
e117778 to
d18cd70
Compare
ndr-ds
force-pushed
the
11-19-catch_performance_regressions_on_benchmark
branch
from
d18cd70 to
b5c3a73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're currently not running benchmarks on PRs and also I'm not sure if we even check these metrics 🤔
Proposal
Run benchmarks on all PRs, and also use TBD solution to catch regressions on the results (and post to the PR).
Test Plan
CI
Release Plan