Client grace period is configurable. #2837
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christos-h
force-pushed
the
grace-period-is-configurable
branch
from
b333caf to
c12fbb0
Compare
|
I'm torn on making a struct GracePeriod(f64);
impl Default for GracePeriod {
fn default() -> Self {
Self(0.1)
}
}
// etc... |
christos-h
force-pushed
the
grace-period-is-configurable
branch
from
c12fbb0 to
9b0c33f
Compare
afck
reviewed
Nov 7, 2024
| @@ -161,7 +159,7 @@ where | |||
| && (highest_key_score >= committee.quorum_threshold() | |||
| || highest_key_score + remaining_votes < committee.quorum_threshold()) | |||
| { | |||
| end_time = Some(Instant::now() + start_time.elapsed().mul_f64(GRACE_PERIOD)); | |||
| end_time = Some(Instant::now() + start_time.elapsed().mul_f64(grace_period)); | |||
There was a problem hiding this comment.
We could do this only in the first case (i.e. if we did reach a quorum).
FYI I created #2836 for this.
ma2bd
reviewed
Dec 16, 2024
| @@ -135,6 +135,9 @@ A Byzantine-fault tolerant sidechain with low-latency finality and high throughp | |||
| Don't include any messages in blocks, and don't make any decision whether to accept or reject | |||
|
|
|||
| * `--restrict-chain-ids-to <RESTRICT_CHAIN_IDS_TO>` — A set of chains to restrict incoming messages from. By default, messages from all chains are accepted. To reject messages from all chains, specify an empty string | |||
| * `--grace-period <GRACE_PERIOD>` — The amount of time we wait for additional validators to contribute to the result, as a fraction of how long it took to reach a quorum | |||
|
|
|||
| Default value: `0.1` | |||
There was a problem hiding this comment.
Please let's keep the current value 0.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The grace period, which is the amount of time we wait for validators to respond after achieving a quorum, is hard coded to 20% which is not optimal for all client use-cases, i.e. when optimising for low latency.
Proposal
Make the grace period configurable as a client option.
Test Plan
Tested manually. 20% improvement (when set to 0) in performance in non-ideal networks, that is, networks which have one or more validators which are slower than a quorum.
Release Plan