JsValue module conversions
#2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
js-module-conversions
branch
2 times, most recently
from
2336392 to
0e1ccad
Compare
Merged
This version includes `JsValue` conversions for `Module` that include type hints.
Twey
force-pushed
the
js-module-conversions
branch
from
0e1ccad to
24410a8
Compare
Twey
force-pushed
the
js-module-conversions
branch
from
24410a8 to
06e81fc
Compare
ma2bd
reviewed
Nov 1, 2024
| impl<T: Send + Sync> Post for T {} | ||
|
|
||
| #[cfg(web)] | ||
| const _: () = { |
There was a problem hiding this comment.
A module does also work but it's not quite as nice (have to import super::* and think up a meaningless name). This is a bit of an idiom.
There was a problem hiding this comment.
Ok I find this syntax a bit sad compared to mod trait_impls or something but if the rest of the team can decide.
There was a problem hiding this comment.
Vote on this was split so I'm going to take the approval and merge — we can reconsider later :)
| @@ -214,6 +213,66 @@ impl UserServiceModule for WasmServiceModule { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(web)] | |||
| const _: () = { | |||
ma2bd
approved these changes
Nov 1, 2024
We actually can't remove this `Send` and `Sync` until we can send the `ExecutionStateRequest`s via `postMessage`, i.e. issue linera-io#2552. That issue is far enough divorced from this code that I don't want to link it here, so let's just remove the TODO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to send cached (precompiled) modules between threads. In the JavaScript case, that means we need to be able to convert the modules into a
JsValuethat is suitable to be sent viapostMessage.Proposal
JsValuefor Wasmer modules (including the type hints and other metadata)wasm::Moduletypelinera-executiontrait objects using a boxed trait object akin todyn-cloneTest Plan
CI for type-correctness, and the actual conversion behaviour has been tested through
linera-web.Release Plan
Links