Don't put new chains in wallet if we don't own them.

[afck]

Motivation

The long chain faucet test fails (os error 16 for me) unless we explicitly forget the opened chains.

It looks like we can't use a faucet with a wallet with 1000 chains in it fails. (I suspect the same would apply to the node service.) This is something we should look into as well.

Proposal

Make the open-chain CLI command not add new chains to the wallet if we don't own them.

Keeping this as a draft for now:

• It's maybe debatable what the desired behavior for the CLI command is.
• The node service mutation doesn't seem to ever add the new chain to the wallet? (Will look into this and create an issue on Monday.)
• We should investigate why the faucet fails if it has 1000 chains in the wallet.

Test Plan

I removed the forget_chain from the test and it still passes now.

Release Plan

• These changes should be backported to the latest devnet branch, then
  • be released in a new SDK.
• These changes should be backported to the latest testnet branch, then
  • be released in a new SDK.

Links

• Fixes Try to use a throwaway key in long faucet chain test #2723
• reviewer checklist

[ma2bd]

Perhaps add a warning and suggest a command to add the chain later?

[afck]

We currently don't have such a command, I think. assign only works if you do have the key. We could add an add-chain command that works like assign but without a key? But then maybe add-chain should replace assign, and the key should be an optional parameter?