linera-witty: use wasmer from git to avoid wasmer-vm dependency
#1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
04-25-Remove_wasmer-vm_from_Witty
branch
4 times, most recently
from
0a9dc6c to
cb28aa8
Compare
jvff
approved these changes
Apr 26, 2024
Twey
force-pushed
the
04-25-Remove_wasmer-vm_from_Witty
branch
from
c85f700 to
ba1bc75
Compare
|
Of course 😉 #1966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
wasmer-vmworks only in a native interpreter environment (i.e. withwasmer/sys), and doesn't even compile forwasm32-unknown-unknown. Thankfully, we only depend onwasmer-vmto get access toStoreObjects.Proposal
I have patched
wasmerin wasmerio/wasmer#4546 to expose the requiredStoreObjectsstruct, meaning we can now accessStoreObjectswithout depending onwasmer-vm. This change will be released in Wasmer 4.2.9, but until then we can patch ourwasmerdependency to use the version from GitHub that merges my patch.Test Plan
CI.
Release Plan
Invisible to users.
Links