Wallet lock files #2053
Comments
Twey
added a commit
to Twey/linera-protocol
that referenced
this issue
Jul 2, 2024
Twey
added a commit
that referenced
this issue
Jul 3, 2024
* `linera-core`: add `Persistent` trait * `linera-service`: use new `Persistent` trait * `linera-service`: don't forget to create the file for `persistent::File::new` * `linera-service`: refresh PRNG seed more to align with tests * `linera-service`: rename `Persistent` to `Persist` This is more in line both with Rust standard library traits, which tend to be transitive verbs, and also with the Rust trait naming conventions RFC rust-lang/rfcs#344, which states: > Prefer (transitive) verbs, nouns, and then adjectives; avoid > grammatical suffixes (like able). * `linera-service`: document `Persist` trait * `linera-service::persistent::File`: when an error occurs during error handling, do not hide the outer error * `linera_service::persistent`: single-space documentation Co-authored-by: Andreas Fackler <[email protected]> Signed-off-by: James Kay <[email protected]> * `linera-service`: mention bug #2053 * `linera_service::proxy`: replace `expect` with `?` * `linera_service::persistent`: use the indicative mood for function documentation --------- Signed-off-by: James Kay <[email protected]> Co-authored-by: Andreas Fackler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current wallet locks apply to the file descriptor, not the path. So they don't apply anymore as soon as we replace the wallet file with a new one. afck@0123e30 would work around this, but a proper fix would be a separate lock file.
The text was updated successfully, but these errors were encountered: