Import kurbo via vello, not glazier.#90
Merged
waywardmonkeys merged 1 commit intolinebender:mainfrom Jul 13, 2023
Merged
Conversation
This makes this consistent in terms of where kurbo things are imported from.
jaredoconnell
approved these changes
Jul 12, 2023
Contributor
jaredoconnell
left a comment
jaredoconnell
left a comment
There was a problem hiding this comment.
This seems like a logical change to me. People will just need to keep an eye on the auto-imports if they use them.
Contributor
Author
|
I had previously opened a discussion in Zulip about this: https://xi.zulipchat.com/#narrow/stream/354396-xilem/topic/Importing.20from.20kurbo |
Philipp-M
approved these changes
Jul 13, 2023
Member
Philipp-M
left a comment
Philipp-M
left a comment
There was a problem hiding this comment.
Makes sense. Vello is semantically closer to kurbo than glazier and staying consistent here is a good idea. Thanks!
xStrom
approved these changes
Jul 13, 2023
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Unifying imports is a good step towards reducing contributor confusion.
The crate sync issue can be handled in other ways and in a different PR, as also discussed in zulip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes this consistent in terms of where kurbo things are imported from.