Skip to content

xilem_web: Remove unused direct dep on kurbo.#293

Merged
waywardmonkeys merged 1 commit intolinebender:mainfrom
waywardmonkeys:xilem_web-remove-unused-dep
May 8, 2024
Merged

xilem_web: Remove unused direct dep on kurbo.#293
waywardmonkeys merged 1 commit intolinebender:mainfrom
waywardmonkeys:xilem_web-remove-unused-dep

Conversation

@waywardmonkeys
Copy link
Contributor

This is always used via peniko.

This is always used via `peniko`.
@waywardmonkeys waywardmonkeys requested a review from Philipp-M May 8, 2024 14:15
@waywardmonkeys
Copy link
Contributor Author

This is an offshoot from #223.

@waywardmonkeys
Copy link
Contributor Author

All uses of kurbo within xilem_web, including the svgtoy sample are via peniko.

xilem_web::svg exports both peniko and peniko::kurbo, so the svgtoy sample is a bit textually unclear about the provenance, but it is via peniko.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

I now think we probably should do this all up the stack, although I still find the tradeoffs annoying

@waywardmonkeys waywardmonkeys added this pull request to the merge queue May 8, 2024
Merged via the queue into linebender:main with commit 300b22c May 8, 2024
@waywardmonkeys waywardmonkeys deleted the xilem_web-remove-unused-dep branch May 8, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants