Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pass the HAS_ACTIVE state up #148

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Nov 21, 2023

Previously, this was being overwritten by each widget as the event went up the tree, so only the root widget could be active

This aligns this code with the druid version (see https://github.com/linebender/druid/blob/e53a5ab72c40191b3f92edef9ebf4da07da254f3/druid/src/core.rs#L812)

Previously, this was being overwritten by each widget as the event
went up the tree, so only the root widget could be active

This aligns this code with the druid version (see
https://github.com/linebender/druid/blob/e53a5ab72c40191b3f92edef9ebf4da07da254f3/druid/src/core.rs#L812)
Copy link
Contributor

@Philipp-M Philipp-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this actually fixes the issue I found

@DJMcNab DJMcNab added this pull request to the merge queue Nov 21, 2023
Merged via the queue into linebender:main with commit cd2f129 Nov 21, 2023
7 checks passed
@DJMcNab DJMcNab deleted the enable_active_state branch November 21, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants