-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge xilem_html
and xilem_svg
as xilem_web
#142
Merge xilem_html
and xilem_svg
as xilem_web
#142
Conversation
c92231d
to
35f0910
Compare
859e712
to
199fee8
Compare
199fee8
to
0183814
Compare
I'm keen for this to happen - I will try to find time for review. |
Extremely awesome! I was able to get my beztoy example ported over with minimal fuss, and I'm looking forward to being able to wire up HTML sliders (I haven't done this yet, but expect it to be straightforward). The one snag I hit is that I had put a I haven't reviewed the code in detail (only checked to see whether it works) but based on a skim I don't have any major concerns. I could do a deeper review if that would be helpful. |
… and IntoAttributeValue::into_attribute_value -> IntoAttributeValue::into_attr_value
Thanks :) Well, I guess I need to dig a little bit deeper what is allowed in SVG and what not (my experience with SVG is limited yet...). (And I renamed I feel rather confident about the code, so a deeper review may be helpful but I don't think it's really necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to merge, as the latest change addresses my concern. Thanks!
xilem_html
and xilem_svg
xilem_html
and xilem_svg
as xilem_web
These got mixed up in linebender#142
Merge these libraries together, as they share a lot of code.
xilem_svg
is completely merged/ported withxilem_html
asxilem_web
(name is open for discussion).The views in xilem_svg were either removed (
Clicked
orGroup
as they're redundant because ofOnClick
orG
(SVG g element)), refactored (add generic parameters, for better generic inference), and/or generalized (e.g.Pointer
which can now be used for allElement
s, orFill
/Stroke
which can also be used for raw SVG elements such as<circle>
or<text>
).This kind of introduces the idea, that a fully-typed close(r) to the spec following HTML/DOM API can coexist with custom views/widgets (in this case kurbo shapes used as SVG basic shapes, previously in
xilem_svg
)