Add cosmic text example #739
Conversation
|
Thanks, it's really good to see this. Would you consider making this a test scene (i.e. in the I think that would be useful because this new example has a lot of interleaving of logic between cosmic text and Vello and winit. If not, I think we can still land this nearly as-is, although it being another usage of winit is likely to cause us pain in future when we need to perform updates. |
|
Sure, I will do that. |
|
|
||
| for (font_id, index) in font_faces { | ||
| if let Some(font) = font_system.get_font(font_id) { | ||
| let resource = Arc::new(font.data().to_vec()); |
There was a problem hiding this comment.
There are two allocations here, one to put the data in the vec, and one to allocate the Arc. The first could be avoided by creating an adapter which implements AsRef<[u8]> by containing an Arc<Font> and using the data parameter. The second would use https://docs.rs/bytemuck/latest/bytemuck/allocation/trait.TransparentWrapperAlloc.html#method.wrap_arc, and is definitely out-of-scope.
The best resolution to this would probably be to have a comment: "These allocations are avoidable, but used for simplicity.", maybe with a link to this comment?
There was a problem hiding this comment.
Not in time for this patch, but improving this is also a design goal for splitting these resource handles out of Peniko. (linebender/peniko#68)
There was a problem hiding this comment.
I have used an adapter and added a link to this comment.
There was a problem hiding this comment.
A wrapper/adapter is fine, but we should probably just submit a PR to cosmic-text to make Font implement AsRef<[u8]>. Alternatively, the correct type can be obtained using unsafe { font_system.db().make_shared_face_data(font_id).unwrap() }.
|
Thanks for the feedback. I will work on this tomorrow. |
| } | ||
| } | ||
|
|
||
| let text = "おはよう (ja) (ohayō) 🌅✨ (morning), こんにちは (ja) (konnichi wa) ☀️😊 (daytime), こんばんは (ja) (konban wa) 🌙🌟 (evening)"; |
There was a problem hiding this comment.
For future reviewers:
These translations do also appear to be correct.
There was a problem hiding this comment.
Would you be able to also document that this exists at the top level of the repository, in https://github.com/linebender/vello?tab=readme-ov-file#integrations
|
Is there anything left here other than what I just commented on? Or is this basically ready to go? It would be nice to land it soon! |
|
I will rebase this hopefully in the next day or two |
AustinMReppert
force-pushed
the
feature/cosmic-text-example
branch
from
14b9023 to
0a1ebba
Compare
vello_tests/Cargo.toml
Outdated
| @@ -22,3 +22,6 @@ nv-flip = "0.1.2" | |||
| image = { workspace = true, features = ["png"] } | |||
|
|
|||
| scenes = { workspace = true } | |||
|
|
|||
| [features] | |||
| cosmic_text = ["scenes/cosmic_text"] | |||
DJMcNab
force-pushed
the
feature/cosmic-text-example
branch
from
0a1ebba to
e504dac
Compare
|
@xStrom are you willing to review the name licensing things I've done here? I think I've covered it properly |
Add an example for cosmic text.
Related:
306