-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Skrifa to 0.22.0 #697
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point, we might want to have a separate cache for autohinting instances the same way we do for glyf and cff but this looks good for now, thanks!
vello_encoding/src/glyph_cache.rs
Outdated
engine: skrifa::outline::Engine::AutoFallback, | ||
target: skrifa::outline::Target::Smooth { | ||
mode: skrifa::outline::SmoothMode::Lcd, | ||
// TODO: Set based on whether the anti-aliasing mode is Area? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should always set this to false as you’ve done here. See googlefonts/fontations#1080
vello_encoding/src/glyph_cache.rs
Outdated
mode: skrifa::outline::SmoothMode::Lcd, | ||
// TODO: Set based on whether the anti-aliasing mode is Area? | ||
symmetric_rendering: false, | ||
// TODO: Does Parley handle layout in a hinting-aware way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parley expects linear metrics. Hinting aware layout requires scaling glyph outlines to compute hinted advance widths which is incredibly expensive.
The main consequence of this is that there is a new auto-hinter.
I've also removed the
glyph
module from Vello, as the actual code in there is never used, as far as I can see.