Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wgpu-profiler #687

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Upgrade wgpu-profiler #687

merged 5 commits into from
Sep 25, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Sep 12, 2024

Fixes #678

@waywardmonkeys
Copy link
Contributor

@DJMcNab This can be changed to 0.18.2 now and should be able to land!

@DJMcNab DJMcNab added this to the Vello 0.3 release milestone Sep 23, 2024
@DJMcNab DJMcNab marked this pull request as ready for review September 23, 2024 10:28
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this doesn't crash anymore on macOS for me ... but now it dies a lot with the negative Duration. But that's how it is on macOS for now...

@DJMcNab
Copy link
Member Author

DJMcNab commented Sep 23, 2024

Dies? It shouldn't crash with a negative duration, it should display the duration as negative, I think?

What's the panic message?

@waywardmonkeys
Copy link
Contributor

thread 'main' panicked at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/time.rs:957:23:
cannot convert float seconds to Duration: value is negative
stack backtrace:
   0: rust_begin_unwind
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panicking.rs:665:5
   1: core::panicking::panic_fmt
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:74:14
   2: core::panicking::panic_display
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:264:5
   3: core::time::Duration::from_secs_f64::panic_cold_display
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panic.rs:101:13
   4: core::time::Duration::from_secs_f64
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/time.rs:957:23
   5: with_winit::stats::draw_gpu_profiling
             at ./examples/with_winit/src/stats.rs:316:41
   6: <with_winit::VelloApp as winit::application::ApplicationHandler<with_winit::UserEvent>>::window_event
             at ./examples/with_winit/src/lib.rs:529:25

@waywardmonkeys
Copy link
Contributor

Just tried with v0.2.1 and it definitely happens more often (almost constantly) now. Of course, the only thing that it is tracking is the render_to_texture, so it is only take some 300 microseconds or so.

Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it.

@DJMcNab DJMcNab added this pull request to the merge queue Sep 25, 2024
@DJMcNab DJMcNab removed this pull request from the merge queue due to a manual request Sep 25, 2024
@DJMcNab DJMcNab added this pull request to the merge queue Sep 25, 2024
Merged via the queue into linebender:main with commit 5ad79d0 Sep 25, 2024
17 checks passed
@DJMcNab DJMcNab deleted the profiler-up branch September 25, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpu profiling validation error after debug layers changes
2 participants