Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[encoding] Do not allow zero-length buffer sizes #365

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[encoding] Do not allow zero-length buffer sizes #365

merged 1 commit into from
Sep 21, 2023

Commits on Sep 21, 2023

  1. [encoding] Do not allow zero-length buffer sizes 

    It is possible for a BufferSize of 0 bytes to trigger validation
warnings as such buffers still need to get bound to their pipeline. The
standard vello engine (src/engine.rs) handles this when a BufProxy is
requested by setting the requested size to at least 16.

This is now handled by the encoding crate by selecting a buffer size
that can fit at least one element.
    @armansito
    armansito committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    1915e5a View commit details
    Browse the repository at this point in the history