[shaders] Option to force read_write access mode on all storage bindings #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphlinus
approved these changes
Sep 21, 2023
|
The CI problem was fixed by the #360 merge. If you merge or rebase against that, it should clear it up. |
Introduced the `force_rw_storage` feature which applies a transformation that converts all read-only storage bindings to have the `read_write` access mode. This is being provided as an optional preprocessor transformation to work around the WebGPU standard's limitation on mixed `storage-read` and `storage` usages by a GPU program over the same buffer object (see https://www.w3.org/TR/webgpu/#programming-model-resource-usages). This limitation makes the WGSL shaders incompatible with (Skia) Graphite's sub-allocating buffer manager when they are run on its Dawn backend. This workaround will be removed once Graphite's buffer management system supports whole buffer bindings.
armansito
force-pushed
the
pr-force_rw_storage-feature
branch
from
081c2ae
to
d47dbfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced the
force_rw_storagefeature which applies a transformation that converts all read-only storage bindings to have theread_writeaccess mode.This is being provided as an optional preprocessor transformation to work around the WebGPU standard's limitation on mixed
storage-readandstorageusages by a GPU program over the same buffer object (see https://www.w3.org/TR/webgpu/#programming-model-resource-usages).This limitation makes the WGSL shaders incompatible with (Skia) Graphite's sub-allocating buffer manager when they are run on its Dawn backend. This workaround will be removed once Graphite's buffer management system supports whole buffer bindings.