Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wgpu 0.17. #350

Merged

Conversation

waywardmonkeys
Copy link
Contributor

This is a draft as it won't land until bevy updates to use wgpu 0.17.

This disables the with_bevy example for now so that we can see that everything else passes the CI checks.

I've run it on Windows with the with_winit example and the SVG tiger and things looked okay to me. (A tiger showed up.)

@waywardmonkeys
Copy link
Contributor Author

@dfrg
Copy link
Collaborator

dfrg commented Aug 1, 2023

Thanks! This looks great and I’d like to go ahead and land it now without waiting on bevy support as it allows us to push other more important work forward.

If you mark it ready for review, I’ll stamp it and we can get it merged.

@waywardmonkeys waywardmonkeys marked this pull request as ready for review August 1, 2023 15:21
@waywardmonkeys
Copy link
Contributor Author

I've marked it as ready for review, but there was discussion during office hours that led to the idea that this wouldn't land until Bevy was ready, I think ...

but up to you (or we wait for this week's office hours)!

Copy link
Collaborator

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw approved in the office hours agenda and assumed someone else stamped this already. Feel free to merge!

@waywardmonkeys waywardmonkeys merged commit fba1b46 into linebender:main Aug 5, 2023
4 checks passed
@waywardmonkeys waywardmonkeys deleted the experimental/wgpu-0.17 branch August 5, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants