Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode alpha for Images #692

Open
DJMcNab opened this issue Sep 20, 2024 · 0 comments
Open

Encode alpha for Images #692

DJMcNab opened this issue Sep 20, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@DJMcNab
Copy link
Member

DJMcNab commented Sep 20, 2024

Currently, when encoding an image, the alpha factor is discarded:

pub fn encode_image(&mut self, image: &Image, alpha: f32) {
let _alpha = alpha * f32::from(image.alpha);
// TODO: feed the alpha multiplier through the full pipeline for consistency
// with other brushes?
// Tracked in https://github.com/linebender/vello/issues/692

The consequences of this are:

To fix this, we need to wire this alpha through to fine (because of #664 and friends), somehow.

github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
This updates Peniko to
[0.2.0](https://github.com/linebender/peniko/releases/tag/v0.2.0).

The main impact this would have on users is being able to set `alpha` on
images, but that is currently broken because of #692.

This also updates to Kurbo
[0.11.1](https://github.com/linebender/kurbo/releases/tag/v0.11.1),
which of note includes linebender/kurbo#353
@DJMcNab DJMcNab added the help wanted Extra attention is needed label Sep 30, 2024
@DJMcNab DJMcNab added this to the Vello 0.4 Release milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant