Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version on main lags behind published crate #684

Closed
marcpabst opened this issue Sep 6, 2024 · 2 comments · Fixed by #715
Closed

Version on main lags behind published crate #684

marcpabst opened this issue Sep 6, 2024 · 2 comments · Fixed by #715

Comments

@marcpabst
Copy link

marcpabst commented Sep 6, 2024

Is this intentional? It's only a minor inconvenience but it leads to subtle incompatibilities (for example, velato will try to pull 0.2.1 from crates.io and I have trouble getting cargo to use the latests main form git instead)

@marcpabst marcpabst changed the title Version on main behin published crate Version on main lags behind published crate Sep 6, 2024
@DJMcNab
Copy link
Member

DJMcNab commented Sep 9, 2024

The history in 0.2.1 diverges from main, so it wouldn't really be accurate to use that version number on main, since the commit which was released was never actually present on main.

You are running into rust-lang/cargo#5640. The workaround I'd suggest for your case is use a patched version of velato pointing at the patch you wish to use, or make a patch of Vello on main which has the version 0.2.0.

We're hoping to make a 0.3.0 release within the next month, which should resolve this. Although I recognise that a month is a long time.

That being said, we are considering following the pattern which Bevy uses, of "eagerly" bumping the version number to something incompatible, to avoid the expectation that this kind of transitive patching is directly supported. This is discussed in bevyengine/bevy#6451. See also linebender/bevy_vello#81

@DJMcNab DJMcNab added this to the Vello 0.3 release milestone Sep 10, 2024
@marcpabst
Copy link
Author

Thanks, I managed to solve my problem for now using a patched version!

github-merge-queue bot pushed a commit that referenced this issue Oct 4, 2024
I have optimistically scheduled it for today. 

Fixes #684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants