-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the latest Linebender CI standard. #588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to land this. Obviously I wasn't previously aware of this PR
piet-cairo/Cargo.toml
Outdated
@@ -1,17 +1,24 @@ | |||
[package] | |||
name = "piet-cairo" | |||
version = "0.7.0" | |||
version.workspace = true | |||
authors = ["Raph Levien <[email protected]>"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably move to the AUTHORS file, I presume that would be a follow-up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well do it here as it's quite straightforward. Added the commit.
rust-version.workspace = true | ||
license.workspace = true | ||
repository.workspace = true | ||
readme = "../README.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... That's not great
piet-common
loses theweb
feature, which was functionally broken anyway as shown by the new CI.The
piet-web
backend was and still is automatically chosen when targetingwasm32
.doc_auto_cfg
feature for docs.rs which will show a little tip next to feature gated functionality informing of the crate feature flag.Cargo.toml
instead of all over the place.Cargo.lock
is now committed.