Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest Linebender CI standard. #588

Merged
merged 13 commits into from
Dec 6, 2024
Merged

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Nov 4, 2024

  • The CI script gets a big update to bring it more in sync with the latest standard.
  • piet-common loses the web feature, which was functionally broken anyway as shown by the new CI.
    The piet-web backend was and still is automatically chosen when targeting wasm32.
  • Enable the doc_auto_cfg feature for docs.rs which will show a little tip next to feature gated functionality informing of the crate feature flag.
  • Piet version is now configured in the workspace Cargo.toml instead of all over the place.
  • Cargo.lock is now committed.
  • Piet now has an explicit MSRV of 1.77 and it's documented.
  • Each published package now has its own copy of the license files.

@xStrom xStrom added the maintenance cleanup and refactoring label Nov 4, 2024
@xStrom xStrom marked this pull request as ready for review November 4, 2024 15:43
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to land this. Obviously I wasn't previously aware of this PR

@@ -1,17 +1,24 @@
[package]
name = "piet-cairo"
version = "0.7.0"
version.workspace = true
authors = ["Raph Levien <[email protected]>"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably move to the AUTHORS file, I presume that would be a follow-up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well do it here as it's quite straightforward. Added the commit.

rust-version.workspace = true
license.workspace = true
repository.workspace = true
readme = "../README.md"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... That's not great

@xStrom xStrom added this pull request to the merge queue Dec 6, 2024
Merged via the queue into linebender:main with commit b0c5d8c Dec 6, 2024
20 checks passed
@xStrom xStrom deleted the syncci branch December 6, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance cleanup and refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants