Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the console feature for web-sys. #586

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Oct 24, 2024

The console feature was only enabled with dev dependencies.

That combined with the Piet CI being of an older Linebender variation that tests with dev dependencies enabled means that the CI didn't catch that piet-web can't actually be compiled.

@xStrom xStrom added the piet-web issue in the web backend label Oct 24, 2024
@xStrom xStrom merged commit 4f30a94 into linebender:master Oct 24, 2024
14 checks passed
@xStrom xStrom deleted the webconsole branch October 24, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
piet-web issue in the web backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant