Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve piet-coregraphics #528

Merged
merged 9 commits into from
Nov 17, 2022
Merged

Improve piet-coregraphics #528

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
51d2729
Fix drawing of cropped images
longmathemagician Jul 28, 2022
e2174dd
Fix formatting (via cargo fmt)
longmathemagician Aug 17, 2022
4f7dc71
Rename method parameter in accordance with coding conventions
longmathemagician Aug 17, 2022
5df4eec
Modify CoreGraphicsContext & capture_image_area to work with both y-u…
longmathemagician Aug 18, 2022
56ea574
Harmonize y-direction
longmathemagician Aug 19, 2022
486153f
Fix clippy dead code check
longmathemagician Aug 19, 2022
ca0f200
Update test case
longmathemagician Aug 19, 2022
f5abbb1
Flush crop after capturing area of a context
longmathemagician Aug 19, 2022
73a44fb
Rename CoreGraphicsImage::as_ref to CoreGraphicsImage::as_cgimage so …
longmathemagician Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions piet-coregraphics/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,7 @@ impl<'a> RenderContext for CoreGraphicsContext<'a> {
) {
if let CoreGraphicsImage::NonEmpty(image) = image {
if let Some(cropped) = image.cropped(to_cgrect(src_rect)) {
// TODO: apply interpolation mode
self.ctx.draw_image(to_cgrect(dst_rect), &cropped);
self.draw_image(&CoreGraphicsImage::NonEmpty(cropped), dst_rect, _interp);
longmathemagician marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
Expand Down