Make new_text_layout take impl Into<Arc<str>> #297
Conversation
cmyr
force-pushed
the
arc-str-in-layout
branch
from
b444e77 to
02e8c59
Compare
|
To explain the rationale here a bit better; besides just cheaper cloning, this fixes an issue that I ran into in linebender/druid#1182. Because we create the layout object lazily in druid, if we don't want to hold onto an additional copy of the text we need to have the text passed in whenever the layout object is rebuilt, which doesn't feel exactly right. |
cmyr
force-pushed
the
arc-str-in-layout
branch
2 times, most recently
from
8650e46 to
4a8d7b6
Compare
This will still allow the simple case of passing a string slice, but will also let druid share string objects with piet, which should enable better APIs that aren't giving up efficiency. Another benefit of this work is making cloning of layout objects cheaper.
cmyr
force-pushed
the
arc-str-in-layout
branch
from
4a8d7b6 to
c79347f
Compare
There was a problem hiding this comment.
Ok, this change is fine, but as discussed in chat this is bringing up some complex issues around cloning and mutability in the existing design - doing a mutation after a clone will affect the original copy. Some deeper thought is needed whether it's even worthwhile having a mutable width change, and if so how to keep it both safe and efficient. Colin will file an issue, and we can discuss there.
|
Okay, going to try this, I think it lets me write a much better API in druid. |
This will still allow the simple case of passing a string slice, but
will also let druid share string objects with piet, which should enable
better APIs that aren't giving up efficiency.
Another benefit of this work is making cloning of layout objects
cheaper.
closes #295