-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm bitmap target #167
Wasm bitmap target #167
Conversation
@elrnv any suggestions for how I should test that this is working as intended? |
Yes! In druid, remove the |
I should emphasize that this is just a placeholder for the implementation. I'm not sure yet how to actually test it. |
this is maybe a bit daft, but what target tam I building? I can't seem to get compilation to fail even without this PR. 😕 |
Ah sorry, I should have been more clear. I guess the idea is that the test harness in druid fails to build without this bitmap target, so to trigger the build of the test harness in druid (for wasm) you need
Of course on top of removing the
To the top level Cargo.toml to ensure that the right piet-common version is being pulled. (BTW It seems like I had some things missing for some reason, but I think the issues should be fixed now). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the walk through, this works for me!
This PR adds a placeholder for the bitmap target rendering mechanism present in other backends. In the current state this PR will enable druid unit tests to be built with WASM, although their execution will need to be thought out further.
I intend this PR to simply get the ball rolling toward getting testing working for the wasm backend in druid since linebender/druid#759 doesn't provide any testing in wasm.