Add test to make sure into_raw_pixels doesn't crash. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphlinus
reviewed
Apr 9, 2020
There was a problem hiding this comment.
The underlying cause is pilot error - the crash is actually because of a missing piet.finish(). When that's added, the test passes.
That's not to say there's no bug though. There's a C++ exception (UB) from ostensibly safe code. We should either silently add a finish call (the impl is idempotent, though the spec doesn't require it) or detect the condition and panic safely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided
into_raw_pixelstest crashes when calling the system d2dEndDrawfuntion. This doesn't seem like desired behavior. If this test does something invalid, I think a Rust panic would be better and if this test should work then we have a bug.Found this issue while investigating druid#784