Switch back to MSRV 1.82 & 2021 edition.#307
Merged
waywardmonkeys merged 1 commit intolinebender:mainfrom Mar 20, 2025
Merged
Conversation
waywardmonkeys
commented
Mar 19, 2025
nicoburns
approved these changes
Mar 19, 2025
xorgy
approved these changes
Mar 19, 2025
We keep the Rust Style Edition 2024, so the formatting changes previously done remain. This reverts parts of commit 7e4aa0b. This is in response to some feedback from potential community users who were concerned about an aggressive MSRV.
waywardmonkeys
force-pushed
the
reduce-msrv
branch
from
e635b0c to
eab612d
Compare
13 tasks
DJMcNab
reviewed
Mar 20, 2025
|
|
||
| /// Returns an iterator over the clusters in logical order. | ||
| pub fn clusters(&'a self) -> impl Iterator<Item = Cluster<'a, B>> + Clone { | ||
| pub fn clusters(&'a self) -> impl Iterator<Item = Cluster<'a, B>> + 'a + Clone { |
Member
There was a problem hiding this comment.
Something something this should probably use the captures trick, but it's also underdocumented and everyone gets this wrong, and we'll be moving to 1.85 in the reasonably near future anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We keep the Rust Style Edition 2024, so the formatting changes previously done remain.
This reverts parts of commit 7e4aa0b.
This is in response to some feedback from potential community users who were concerned about an aggressive MSRV.