Implement the reinterpret operations without bytemuck #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #116, because it touches some of the codegen stuff I cleaned up in that PR. it's unfortunate that GitHub doesn't have stacked PRs.
We have the
Bytestrait, which lets us cast SIMD types to and from raw bytes (currently usingmem::transmute). We can use itsbitcastmethod instead of pulling in bytemuck for the "reinterpret" operations onFallback.On the x86 side, we can use the
_mm_cast[...]intrinsics. All the x86 integer types are__m128ior__m256i, so conversions between integer widths are no-ops.While working on this, I noticed that there are "reinterpret signed as unsigned" ops, but no corresponding "reinterpret unsigned as signed" ops. Are the reinterpret ops worth it at this point if we have the
Bytestrait?