Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do doc tests with the stable compiler. #985

Merged
merged 1 commit into from
May 25, 2020
Merged

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented May 25, 2020

Our doc tests are marked as required, so they should be done with the stable compiler instead. The nightly compiler has an issue right now and it's blocking merges.

@xStrom xStrom added maintenance cleans up code or docs S-needs-review waits for review labels May 25, 2020
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable!

@luleyleo luleyleo removed the S-needs-review waits for review label May 25, 2020
@xStrom xStrom merged commit 5b10bdb into linebender:master May 25, 2020
@xStrom xStrom deleted the ci-nightly branch May 25, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance cleans up code or docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants