Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Button::dynamic constructor #963

Merged
merged 3 commits into from
May 21, 2020
Merged

Add Button::dynamic constructor #963

merged 3 commits into from
May 21, 2020

Conversation

totsteps
Copy link
Collaborator

closes #899

cmyr
cmyr approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

druid/src/widget/label.rs Show resolved Hide resolved
luleyleo
luleyleo requested changes May 21, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!
The changlog entry is not at the right place yet, but the rest looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
@luleyleo luleyleo added the S-waiting-on-author waits for changes from the submitter label May 21, 2020
@totsteps totsteps added S-needs-review waits for review and removed S-waiting-on-author waits for changes from the submitter labels May 21, 2020
luleyleo
luleyleo approved these changes May 21, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@luleyleo luleyleo removed the S-needs-review waits for review label May 21, 2020
@cmyr cmyr merged commit 208e00a into linebender:master May 21, 2020
@totsteps totsteps deleted the button-dynamic branch May 21, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luleyleo luleyleo luleyleo approved these changes

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Button::dynamic constructor
3 participants
@totsteps @cmyr @luleyleo