Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify app data type checks. #945

Merged
merged 1 commit into from
May 16, 2020
Merged

Simplify app data type checks. #945

merged 1 commit into from
May 16, 2020

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented May 15, 2020

This PR simplifies the data type checks introduced in #931.

@xStrom xStrom added the S-needs-review waits for review label May 15, 2020
luleyleo
luleyleo approved these changes May 16, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sens. When I wrote that I had my typed selectors PR in mind and for that I would have needed the specific types. But as I intend to do it a bit differently now anyways, there is no need for that anymore, thanks!

@luleyleo luleyleo added S-waiting-on-author waits for changes from the submitter and removed S-needs-review waits for review labels May 16, 2020
@xStrom xStrom removed the S-waiting-on-author waits for changes from the submitter label May 16, 2020
@xStrom xStrom merged commit a480919 into linebender:master May 16, 2020
@xStrom xStrom deleted the type-t branch May 16, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luleyleo luleyleo luleyleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xStrom @luleyleo