-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X11: Add support for window closing and quitting. #900
Conversation
I also implemented I also added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this! Makes the X11 shell pretty much even with GTK, except for menus of course.
I added more code comments to hopefully make things clearer. I also removed connection flushing from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The doc-links are definitely useful.
This PR adds support for closing individual windows. Previously closing any window would close all of them. This can be tested with the
multiwin
example.Additionally I refactored some code and added more inline documentation.