Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper CI testing coverage and optimize it for speed. #857

Merged
merged 2 commits into from
Apr 17, 2020

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Apr 17, 2020

I spent some time really reading through the cargo docs and inspecting our workspace structure. This PR is the result of that. It covers more code and is faster.

  • Made sure everything is tested on all target combinations. There were some holes with examples, including book examples. Also nightly and wasm testing were limited.
  • Removed redundant cargo rustc steps as cargo clippy already compiles the code and fails on the same warnings. I verified this and it's stated in the clippy readme:

Note that adding -D warnings will cause your build to fail if any warnings are found in your code. That includes warnings found by rustc (e.g. dead_code, etc.).

  • Brought X11 testing into the main job as an end phase on Ubuntu, because it shares a lot of dependencies that are already built.
  • Added various comments to the CI file for future editors.

@cmyr
Copy link
Member

cmyr commented Apr 17, 2020

Wonderful, the problem with this stuff is definitely maintenance; it seems to consistently degrade over any serious set of changes. Hopefully we don't have too many additional targets coming in the near future, though? 😬

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a skim. Thanks for taking this on!

@xStrom xStrom merged commit d8b6e14 into linebender:master Apr 17, 2020
@xStrom xStrom deleted the streamline-ci branch April 17, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants