Update to piet v0.0.12 #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In tests/harness.rs: let mut harness = Harness {
piet,
inner,
window_size: DEFAULT_SIZE,
};
f(&mut harness);
harness.piet.finish().expect("piet finish failed"); // <--- Add this line |
futurepaul
reviewed
Apr 9, 2020
| @@ -89,7 +89,7 @@ impl TextBox { | |||
| .unwrap(); | |||
|
|
|||
| piet_text | |||
| .new_text_layout(&font, &text.to_string()) | |||
| .new_text_layout(&font, &text.to_string(), std::f64::INFINITY) | |||
There was a problem hiding this comment.
When I hit enter in the hello.rs example, the cursor gets into a weird state (previously it would just print the box character). I'm on linux haven't tried it on mac yet.
There was a problem hiding this comment.
For me the cursor goes to the beginning of the textbox and the label is multi-line. Certainly broken, but probably as simple as disabling enter for now.
There was a problem hiding this comment.
okay, I'm going to patch that here as well; we will suppress enter in the textbox widget. (this isn't perfect, since you could still paste one in, but I think it's a good initial step. We need to figure out a whole whack of new text stuff, now.)
This gives us blurred rects as well as multi-line text.
raphlinus
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us blurred rects as well as multi-line text.
this unblocks #759