Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditableLabel proof of concept #810

Closed
wants to merge 1 commit into from
Closed

Add EditableLabel proof of concept #810

wants to merge 1 commit into from

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Apr 7, 2020

This is a fairly simple widget that displays a label that can be edited on click. The input is validated, and the data is only mutated when editing completes.


This is something I need in runebender. I don't want to merge this in its current state, but wanted to see what people think; it illustrates some of how I've been thinking about validation in general.

I'm not opposed to merging something like this, as a temporary measure, but I would want to at least remove the changes to the hello example.

2020-04-07 10 16 33

This is a fairly simple widget that displays a label that can be edited on click. The input is validated, and the data is only mutated when editing completes.
@ForLoveOfCats
Copy link
Collaborator

I'm probably being dense but in which ways does this differ from a TextBox?

@cmyr
Copy link
Member Author

cmyr commented Apr 7, 2020

it looks like a label when it isn't being edited; it has a non String data type (kind of like Parse, but more general); and the data doesn't change until the user ends editing, by pressing return or switching the focus.

@cmyr cmyr closed this Apr 12, 2020
@cmyr cmyr deleted the editable-label branch April 12, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants