Move Application:: hide_application, hide_others and set_menu to Mac platform extension #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
approved these changes
Jul 7, 2021
| @@ -183,10 +183,18 @@ pub mod sys { | |||
| /// Quit the running application. This command is handled by the druid library. | |||
| pub const QUIT_APP: Selector = Selector::new("druid-builtin.quit-app"); | |||
|
|
|||
| /// Hide the application. (mac only?) | |||
| /// Hide the application. (mac only) | |||
| #[cfg_attr( | |||
There was a problem hiding this comment.
I spent a few minutes thinking about whether this is too fancy, but I think it's a good change. 👍
|
why are |
not for any concrete reason. |
|
lets leave it for now and allow(deprecated). I would prefer it to be separate PR, if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.