Fix focus on hidden widget in Either #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Yeah, I was thinking about checking all children-hiding widgets, Tabs was on the top of my list. |
|
Tabs, Viewswitcher and Either are the only one i can think of and Viewswitcher already does it. |
lisael
force-pushed
the
fix_focus_in_either
branch
from
968554d to
926bb1f
Compare
|
I did the change on |
lisael
force-pushed
the
fix_focus_in_either
branch
from
4b629df to
850f0c5
Compare
I couldn't reproduce the bug in the example as the tab bar steals the focus anyway when we click on a tab Whatever, it's still cleaner. I also removed spurious ctx.request_layout calls, as it's already called in ctx.children_changed
lisael
force-pushed
the
fix_focus_in_either
branch
from
850f0c5 to
742b283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1858