Add example to ViewSwitcher

[arifd]

Let me know if you don't like it, I should modify anything? I'm hoping to add examples to many more areas of Druid that could benefit from them.

[arifd]

I have been thinking and talking about this here

And it is maybe worth considering that a proper documenting strategy should be born.

Tbh, even though it's kind of common sense, as per Rust's guidelines, I think the current PR fails [at least one code example that users can copy/paste to try it] Because it cannot be copy/pasted without the user knowing that he has to lens onto Foo. Also, Foo does not offer any meaningful example. Thus it is not realworld, it is ugly, and was lazy of me (sorry) truth be told.

[jneem]

Did you reach a conclusion about this? FWIW, I don't think it's necessary to have a main, because if you repeat that for every example, it's a lot of boilerplate...

[arifd]

There has been no feedback to date. And so it's kind of stuck.

[jneem]

Well in that case I suggest we just merge it. Having an example is clearly better than not having one, so there's no point in being stuck on it. Any objections? (edited to add: if there aren't any by tomorrow, I'll merge it)

[maan2003]

the example should be in top level docs of ViewSwitcher not ViewSwitcher::new?

[arifd]

Good question. I wanted it in `new()` because that's when I need to be reminded of the order of the parameters in the closures.

…

On Wed, 16 Jun 2021, 05:59 Manmeet Maan, ***@***.***> wrote: the example should be in top level docs of ViewSwitcher not ViewSwitcher::new? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1822 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR4WFRITN7V34BNHADEMALTTAOTFANCNFSM46HW7GSA> .

[maan2003]

Merging, as no objections