Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make book example code compile #1806

Closed
wants to merge 1 commit into from
Closed

Make book example code compile #1806

wants to merge 1 commit into from

Conversation

JeftavanderHorst
Copy link

This example code doesn't work since it calls build_ui rather than passing it directly. Removing the parentheses fixes the problem. Note that this is my first interaction with druid, so my fix may not be idiomatic? Would love to hear of a better solution if that's the case.

This example code doesn't work since it calls `build_ui` rather than passing it directly. Removing the parentheses fixes the problem. Note that this is my first interaction with druid, so my fix may not be idiomatic? Would love to hear of a better solution if that's the case.
@CryZe
Copy link
Contributor

CryZe commented May 24, 2021

I believe both the book and the README are intended to talk about 0.7 rather than the master branch.

@JeftavanderHorst
Copy link
Author

JeftavanderHorst commented May 24, 2021

I'm using druid 0.7.0, not the master branch. Also, I'm on rustc 1.52.1 on windows 10. Is this api changing in druid 0.8?

@maan2003
Copy link
Collaborator

Yes the book is targeting the git version

I'm using druid 0.7.0, rustc 1.52.1, windows 10. Is this api changing in druid 0.8?

Yes See #1559

@JeftavanderHorst
Copy link
Author

Cool, my bad then. I'll close the pr

@JeftavanderHorst JeftavanderHorst deleted the patch-1 branch May 24, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants