Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X11 cursors #1755

Merged
merged 3 commits into from
May 3, 2021
Merged

X11 cursors #1755

merged 3 commits into from
May 3, 2021

Conversation

maan2003
Copy link
Collaborator

@maan2003 maan2003 commented May 3, 2021

Custom cursors are still TODO.

@maan2003 maan2003 added S-needs-review waits for review shell/x11 concerns the X11 backend labels May 3, 2021
jneem
jneem approved these changes May 3, 2021
View reviewed changes
Copy link
Collaborator

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! I made two minor nitpicks; you can decide for yourself what to do about them.

druid-shell/src/platform/x11/application.rs Outdated Show resolved Hide resolved
druid-shell/src/platform/x11/window.rs Outdated Show resolved Hide resolved
@jneem
Copy link
Collaborator

jneem commented May 3, 2021

btw, have you seen the list of default cursors? It's pretty hilarious...

@maan2003
Copy link
Collaborator Author

maan2003 commented May 3, 2021

btw, have you seen the list of default cursors? It's pretty hilarious...

Oh, I missed this 🤣 . I just followed the freedesktop cursor spec

@jneem
Copy link
Collaborator

jneem commented May 3, 2021

I can't imagine why freedesktop decided to exclude XC_gumby...

@maan2003 maan2003 removed the S-needs-review waits for review label May 3, 2021
@maan2003 maan2003 merged commit 20f05cc into linebender:master May 3, 2021
@psychon psychon mentioned this pull request May 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneem jneem jneem approved these changes

Assignees
No one assigned
Labels
shell/x11 concerns the X11 backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maan2003 @jneem