Switch to trace-based logging #1562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick note: I haven't actually tested the changes on a Windows, MacOs or wasm32 platform. I have ran |
* Add dependency to `tracing` * Convert `log::foobar` calls to `tracing::foobar` * Remove default dependency to `log` * Add `default-logger` feature * Add dev-dependency to `test-env-log` * Replace `console_log` with `tracing-wasm`
|
@raphlinus The CI gives me Error: failed to run custom build command for `pango-sys v0.10.0`Any idea what that means? |
|
Unfortunately I do not. It seems likely unrelated to your trace PR, but it would take some digging to figure out what's going wrong here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracinglog::foobarcalls totracing::foobarlogdefault-loggerfeaturetest-env-logconsole_logwithtracing-wasm