Various image improvements #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-uk1
force-pushed
the
image_clip_and_share
branch
from
fafdf4c to
d2c4ffd
Compare
|
I didn't realise that I've also added a test to check that an empty image doesnt cause a panic. I think the test will currently fail, but I have a PR in for piet (#365) that will let it pass. |
richard-uk1
force-pushed
the
image_clip_and_share
branch
from
5f97151 to
521cab1
Compare
richard-uk1
force-pushed
the
image_clip_and_share
branch
from
5aa4247 to
989b7cc
Compare
richard-uk1
changed the title
clip_area and from_shared to Image.
richard-uk1
force-pushed
the
image_clip_and_share
branch
2 times, most recently
from
c60a2e3 to
880e560
Compare
Merged
|
@derekdreery any interest in getting this landed? I'd like to do a release shortly. |
|
Ooh I'll revisit. |
|
Currently working on this. |
richard-uk1
force-pushed
the
image_clip_and_share
branch
from
880e560 to
087b20f
Compare
|
Looks like the new rust version introduced some new clippy lints. I'll fix them in this PR. |
|
I will submit a piet patch. |
|
Ok with the |
Also add a test to check rendering an empty picture doesn't cause a panic
This commit improves the coverage and accuracy of svg support in the `Svg` widget.
richard-uk1
force-pushed
the
image_clip_and_share
branch
from
e616420 to
fd611b8
Compare
richard-uk1
force-pushed
the
image_clip_and_share
branch
from
fd611b8 to
f8fe8bc
Compare
|
Woop clippy fixed 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently blocked on a new release of piet.
This patch adds 3 features:
Send + Syncbound todyn Errors fromimage. This means that, for example, you can load an image on a dedicated IO thread, and pass the error back to the UI thread.Svgwidget.This allows, for example, a sprite sheet to be shared between multiple
Imagewidgets. It also allows my motivating use case, which is an image viewer where the user can zoom in on part of the image.I've made the changes so they are backwards compatible.
Update: this patch is growing a bit, but each commit is completely disjoint and can be reviewed/accepted separately.
Note: edited heavily.