Allow setting the cursor in the update method. #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
Sounds reasonable. Ultimately I don't love how we handle custom cursors, but it works for now.
Edit to clarify: what I don't like is how we set it on every event, which feels inelegant. It would be nice if a widget could just indicate what cursor should be used when it is hot, and then it could override this as needed? or something?
|
yeah having to set it explicitly every event seems off and confusing for newcomers as well. |
|
Yeah, that makes total sense. I'm going to go ahead and push this, though, and I'll open an issue for the other thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation is that I have a widget that needs to change its cursor in response to the app data, but the data can get changed by keyboard shortcuts that don't cause an event to the relevant widget (e.g. keyboard shortcuts for menu entries).