First cut at request_update #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1073. This version is largely for discussion, as it hasn't been tested at all.
rjwittams
reviewed
Aug 20, 2020
druid/src/contexts.rs
Outdated
| /// | ||
| /// After this, `update` will be called on the widget in the next update cycle, even | ||
| /// if there's not a data change. | ||
| pub fn request_update<T, W>(&mut self) { |
There was a problem hiding this comment.
Generic parameters aren't needed here
|
This does now work for e.g Tabs in my binding-scroll branch |
Remove the `request_update_child` variant, as it likely won't be used. Add changelog.
I forgot a commit number was already assigned, as this was in draft. Also remove generic parameters, as per review.
cmyr
approved these changes
Aug 20, 2020
druid/src/tests/mod.rs
Outdated
Comment on lines
476
to
479
| if let Event::Command(cmd) = event { | ||
| if cmd.is(REQUEST_UPDATE) { | ||
| ctx.request_update(); | ||
| } |
There was a problem hiding this comment.
I would now probably write this as,
if matches!(event, Event::Command(cmd) if cmd.is(REQUEST_UPDATE)) {
ctx.request_update();
}but either works I think.
| /// Request an update cycle. | ||
| /// | ||
| /// After this, `update` will be called on the widget in the next update cycle, even | ||
| /// if there's not a data change. |
There was a problem hiding this comment.
I think it's worth highlighting that this method is only exposed for special cases, such as when a container widget is synthesizing data for its children, and that in general it should be unnecessary/avoided.
| assert!(!updated.get()); | ||
| harness.submit_command(REQUEST_UPDATE, None); | ||
| assert!(updated.get()); | ||
| }) |
There was a problem hiding this comment.
nice to see how straight forward and readable this is.
cmyr
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1073. This version is largely for discussion, as it hasn't been
tested at all.