Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added selection text color to textbox. #1093

Merged
merged 2 commits into from
Jul 26, 2020
Merged

Added selection text color to textbox. #1093

merged 2 commits into from
Jul 26, 2020

Conversation

sysint64
Copy link
Contributor

Here's what it looks like:

image

@luleyleo luleyleo added the S-needs-review waits for review label Jul 18, 2020
jneem
jneem approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It will probably need some changes once the text rework is done, but it doesn't really add complexity so I think it's fine to get this in before then.

@jneem jneem added S-waiting-on-author waits for changes from the submitter and removed S-needs-review waits for review labels Jul 23, 2020
cmyr
cmyr approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks!

@cmyr cmyr merged commit 0cd259b into linebender:master Jul 26, 2020
@xStrom xStrom removed the S-waiting-on-author waits for changes from the submitter label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

@jneem jneem jneem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sysint64 @jneem @cmyr @xStrom @luleyleo