Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show scroll when changing size #1129

Closed
MGlolenstine opened this issue Aug 14, 2020 · 3 comments · Fixed by #1278
Closed

Show scroll when changing size #1129

MGlolenstine opened this issue Aug 14, 2020 · 3 comments · Fixed by #1278
Labels
bug does not behave the way it is supposed to D-Easy just needs to be implemented widget concerns a particular widget

Comments

@MGlolenstine
Copy link
Contributor

If we scroll and show the scrollbar, we can see it's size changing, but if we keep on changing the height of the content, it eventually fades away.
Would there be a way to keep it if the content is changing. That's how most other frameworks do it, just do that you know that something's changing.
@luleyleo
Copy link
Collaborator

luleyleo commented Aug 14, 2020 •
edited
Loading

What platform are you using? I tried it with GTK and X11 and both keep the bar visible as long as I keep resizing.

@luleyleo luleyleo added the bug does not behave the way it is supposed to label Aug 14, 2020
@MGlolenstine
Copy link
Contributor Author

MGlolenstine commented Aug 14, 2020 •
edited
Loading

I'm on Linux, GTK as well... You resize what? I tried it with the list example and if you keep on adding items, the scroll starts acting up.

EDIT: At first I was testing it out with master branch from Github, but then I switched to the crates.io 0.6.0 and the issue persisted.

@luleyleo
Copy link
Collaborator

Oh, my bad

changing the height of the content

missed the "content", thought you were referring to changing the windows size.

I think we can fix this by showing the scroll bar whenever the content size changes (during layout), should be easy to fix.

@luleyleo luleyleo added D-Easy just needs to be implemented widget concerns a particular widget labels Aug 14, 2020
Majora320 added a commit to Majora320/druid that referenced this issue Oct 4, 2020
@Majora320
Fix linebender#1129 and add request_timer to LayoutCtx
3527686
@Majora320 Majora320 mentioned this issue Oct 4, 2020
Merged
@cmyr cmyr closed this as completed in #1278 Oct 5, 2020
cmyr pushed a commit that referenced this issue Oct 5, 2020
@Majora320
Fix #1129 and add request_timer to LayoutCtx (#1278)
f476691 
* Fix #1129 and add request_timer to LayoutCtx

* Update CHANGELOG.md

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug does not behave the way it is supposed to D-Easy just needs to be implemented widget concerns a particular widget
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1129 and add request_timer to LayoutCtx Majora320/druid
2 participants
@MGlolenstine @luleyleo